WORK-459
ID:WORK-459Status:done

Preset scope and tunedFor metadata with pack-manifest validation

SPEC-111 §2,§3,§4 — make scope a validated property, record advisory tunedFor, and validate the pack manifest (module resolvability + scope-vs-actual-tokens + tunedFor well-formedness).

Priority:mediumComplexity:moderateMilestone:v0.25.0Source:SPEC-111
changeset-release/main View source

Criteria completion

Criteria completion: 4 of 4 (100%) checked; tracking started on Jun 24, no incremental history yet0%25%50%75%100%Jun 24Jul 11

Tracking started Jun 24 — check back for trends.

Relationships

Implements 1
Related 3
Branches 3
changeset-release/main current done
main doneclaude/v0.25.0-impl doneclaude/v0.25.0-workitems ready
History 1
  1. 2264093
    Created (done)by github-actions[bot]

Acceptance Criteria

  • Each preset declares scope (syntax | palette) in the manifest entry; a declared syntax preset that sets chrome tokens is a validation warning (reusing filterScopeEligible)
  • tunedFor (preset → themes) is advisory; absence means universal; applying a preset outside its set is never an error
  • Pack-manifest validation checks each module resolves, scope-vs-actual-tokens agreement, and tunedFor well-formedness
  • Validation folds into the existing config/theme validation surface (and the scaffold's manifest-validate)

Approach

Reuse the engine's existing filterScopeEligible classification (packages/transform/src/token-stylesheet.ts) to compare a preset's actual token namespaces against its declared scope. Wire the checks into the shared validation surface.

Dependencies

  • WORK-456 — the pack format / manifest
  • WORK-457 — loading a preset to inspect its tokens

References

  • SPEC-111 §2, §3, §4; packages/transform/src/token-stylesheet.ts (filterScopeEligible)

Resolution

Completed: 2026-06-23

Branch: claude/v0.25.0-impl

What was done

  • presetChromeKeys() + validatePresetEntry() in install.ts: a syntax-scoped preset that sets any color.* (other than code) — top-level or under modes.*.color — warns "really a palette preset"; invalid scope errors; malformed tunedFor warns. Unit-tested (4 cases).
  • theme presets validate (presets.ts) checks module resolvability + (for JSON-carrier presets) scope-vs-actual-tokens + tunedFor well-formedness; JS/TS carriers are checked for resolvability (token check skipped pending build). Verified: all 9 Lumina presets validate clean; a synthetic mis-scoped preset is flagged.

Notes

  • filterScopeEligible is private and tint-projection-oriented; I implemented the equivalent syntax-vs-chrome split (syntax + color.code allowed; other color.* = chrome) rather than exporting it. Applying outside tunedFor is never an error — only list flags it advisorily.